Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove collapseAtStart #6061

Closed
wants to merge 1 commit into from
Closed

Remove collapseAtStart #6061

wants to merge 1 commit into from

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented May 8, 2024

Not used?

@vercel Vercel
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 3:44pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 3:44pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.69 KB (-0.23% 🔽) 474 ms (-0.23% 🔽) 156 ms (+224.61% 🔺) 630 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.27 KB (-0.03% 🔽) 686 ms (-0.03% 🔽) 240 ms (+54.83% 🔺) 925 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 34.25 KB (-0.13% 🔽) 686 ms (-0.13% 🔽) 167 ms (-7.71% 🔽) 852 ms

@ivailop7
Copy link
Collaborator

ivailop7 commented May 9, 2024

Tests failing, but I like the direction of the PR :)

@acywatson
Copy link
Contributor

To borrow a phrase from @trueadm: "what're you on about?" lol

This is definitely used:

lexical/packages/lexical/src/LexicalSelection.ts

Line 1686 in 83fd6fa

anchorNode.collapseAtStart(this);

@acywatson acywatson closed this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zurfyx @ivailop7 @acywatson @facebook-github-bot