[lexical] Feature: error checking for node key re-use with type mismatch in __DEV__ #6014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on issues that several people have run into, it seems useful to add some additional invariant checking around node keys.
See also: discord message
__DEV__
check to make sure that if a new Node is created with an explicit existing key, that the type of the node did not changeTest plan
Before
Bad things will silently happen if you accidentally re-use node keys, such as with a subtly incorrect node replacement function:
After
An error message is shows up now, in
__DEV__.
There are unit tests that verify that the specific error message comes up when creating a new node in this way (tested in isolation and with a node replacer).