Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix -Wbitwise-instead-of-logical in 5 files starting w/ fbpcs/emp_games/pcf2_attribution/AttributionRule_impl.h #9310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix -Wbitwise-instead-of-logical in 5 files starting w/ fbpcs/emp_games/pcf2_attribution/AttributionRule_impl.h #9310

wants to merge 1 commit into from
+9 −1

Commits on Jan 7, 2023

  1. Fix -Wbitwise-instead-of-logical in 5 files starting w/ fbpcs/emp_gam… 

    …es/pcf2_attribution/AttributionRule_impl.h (facebook#9310)

Summary:
Pull Request resolved: facebook#9310

X-link: facebookincubator/dynolog#89

X-link: facebookresearch/fbpcf#462

X-link: facebookresearch/fbpcs#2016

With LLVM-15, `&&` and `||` are required for boolean operands, rather than `&` and `|` which can be confused for bitwise operations. Fixing such ambiguity helps makes our code more readable.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Differential Revision: D42347735

fbshipit-source-id: 3ec9c8af880cfce6490787662a4c3bc28f990bc7
    @r-barnes @facebook-github-bot
    r-barnes authored and facebook-github-bot committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    dd4be07 View commit details
    Browse the repository at this point in the history