Forbid unstructured annotations on field types

Reviewed By: vitaut, createdbysk

Differential Revision: D67951605

fbshipit-source-id: 9eeb681f2fa688aa6c7529c37f6f1319a00d7c94

thrift/compiler/sema/sema_context.h

@@ -89,7 +89,7 @@ class node_metadata_cache {
 };
 
 struct sema_params {
-  bool forbid_unstructured_annotations_on_field_types = false;
+  bool forbid_unstructured_annotations_on_field_types = true;
   bool skip_lowering_type_annotations = false;
 
   /**

thrift/compiler/test/compiler_test.cc

@@ -702,6 +702,7 @@ TEST(CompilerTest, annotation_positions) {
     }
     struct Foo {
       1: i32 (annot) f
+      # expected-error@-1: Annotations are not allowed in this position. Extract the type into a named typedef instead.
       @Type{name="foo"}
       2: i32 g
     }
@@ -808,6 +809,7 @@ TEST(CompilerTest, cpp_type_compatibility) {
     struct B {
       @cpp.Adapter{name="Adapter"} # expected-warning: At most one of @cpp.Type/@cpp.Adapter/cpp.type/cpp.template can be specified on a definition.
       1: i32 (cpp.type = "std::uint32_t") field; # expected-warning@-1: The cpp.type/cpp.template annotations are deprecated, use @cpp.Type instead
+      # expected-error@-2: Annotations are not allowed in this position. Extract the type into a named typedef instead.
       @cpp.Adapter{name="Adapter"} # expected-warning: At most one of @cpp.Type/@cpp.Adapter/cpp.type/cpp.template can be specified on a definition.
       @cpp.Type{name="std::uint32_t"}
       2: i32 field2;