Skip to content

Commit

Permalink
Update doc around function support
Browse files Browse the repository at this point in the history
Summary: These are now supported fully!

Reviewed By: vitaut

Differential Revision: D67996077

fbshipit-source-id: 30448a3612e622c6a8c8b5a8785ca263dd989ba3
  • Loading branch information
praihan authored and facebook-github-bot committed Jan 10, 2025
1 parent d14e4ef commit 33017d6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 2 additions & 0 deletions thrift/compiler/whisker/object.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ namespace whisker {
// identifier, and the value is a `whisker::object` (recursive)
// * native_object —
// User-defined (C++) type with lazily evaluated properties.
// * native_function —
// User-defined (C++) function that operates on `whisker::object`.
//
// Currently, the Whisker templating language only supports i64, null, string,
// and boolean as literals. However, the evaluation engine can recognize all of
Expand Down
4 changes: 0 additions & 4 deletions thrift/doc/contributions/whisker.md
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,6 @@ There are three types of `expression`s in Whisker:
* `{{ (uppercase "hello") }}`
* `{{ (concat (uppercase person.firstName) " " (uppercase person.lastName)) }}`

:::warning
Function call expressions are only partially implemented.
:::

:::note
The `and` and `or` builtin functions short-circuit their evaluation, meaning additional arguments will not be evaluated or checked for errors once the result is determined.
:::
Expand Down

0 comments on commit 33017d6

Please sign in to comment.