This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
[apple_asset_catalog] Include Product Type in AcTool Args #2403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, building Messages extensions with buck will not generate the Messages app icon correctly. This is because in order to do so,
actool
needs to know what product type it is creating an asset catalog + app icon for.This change funnels the product type from apple_bundle into AppleAssetCatalog and AcToolStep so that
actool
is called with--product-type <product type>
(needs to becom.apple.product-type.app-extension.messages
for Messages extensions).