Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): demos code #77

Open
wants to merge 11 commits into
base: development-gatsby
Choose a base branch
from
Open

fix(): demos code #77

wants to merge 11 commits into from

Conversation

ShaMan123
Copy link

Now supports a js file
I want to rename the file code.js => index.js but I didn't to keep the diff sane

x

rename

migrate

x

m
@ShaMan123 ShaMan123 requested a review from asturur August 21, 2023 07:31
Copy link
Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready

Copy link
Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready

@ShaMan123 ShaMan123 mentioned this pull request Aug 21, 2023
Update index.md
@asturur
Copy link
Member

asturur commented Aug 24, 2023

I don't want to think about this now, there are too many changes and i m not sure every is needed.
For example now the code editor is part of the demo template that limit in flexibility on what you can do, and is unclear how i export 2 functions to assign to two different editors.
This is not urgent imho and we can see how to keep functions in the moment we have a larger amount of demos available, this is why i rushed to fix it with the const string, because for now is not necessary to put time on it.

Is ok to write the code in a function while developing it and then change it to a const when we are done, we can also just do that at runtime and live the functions.

@ShaMan123
Copy link
Author

I disagree, for me is a pain

@ShaMan123
Copy link
Author

but anyways I won't be working on demos for a while and I guess you will finish them

@asturur
Copy link
Member

asturur commented Aug 24, 2023

I disagree, for me is a pain

i opened a pr, i couldn't fix it, i wrote that we know we didn't like it, and that it wasn't important to fix it immediately.

Rushing to counter my pr because you don't like the const string while i m still working on demos is not useful.

at the end we will have a js file

@ShaMan123 ShaMan123 mentioned this pull request Aug 26, 2023
asturur pushed a commit that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants