Update to Electron 9

[cmeeren]

The app runs fine, but the extensions don't seem to work properly. Furthermore, there are some warnings in the console.

I'd appreciate if someone who cares could look into this. Unfortunately I can't prioritize this right now.

Here is the console output:

┏ Electron -------------------

  (electron) 'BrowserWindow.getDevToolsExtensions' is deprecated and will be removed. Please use 'session.getAllExtensions' instead.

┗ ----------------------------
┏ Electron -------------------

  (electron) 'BrowserWindow.addDevToolsExtension' is deprecated and will be removed. Please use 'session.loadExtension' instead.

┗ ----------------------------
┏ Electron -------------------

  Added extension {
    id: 'aadbkdhccclfgfebhbaicdfmedeaikpp',
    name: 'React Developer Tools',
    path: 'C:\\Users\\Christer\\AppData\\Roaming\\Electron\\extensions\\fmkadmapgofadopljbjfkapdkoienihi',
    url: 'chrome-extension://aadbkdhccclfgfebhbaicdfmedeaikpp/',
    version: '3.4.2',
    manifest: {
      background: { persistent: false, scripts: [Array] },
      browser_action: { default_icon: [Object], default_popup: 'popups/disabled.html' },
      content_scripts: [ [Object] ],
      content_security_policy: "script-src 'self' 'unsafe-eval'; object-src 'self'",
      description: 'Adds React debugging tools to the Chrome Developer Tools.',
      devtools_page: 'main.html',
      icons: {
        '16': 'icons/16-production.png',
        '32': 'icons/32-production.png',
        '48': 'icons/48-production.png',
        '128': 'icons/128-production.png'
      },
      manifest_version: 2,
      minimum_chrome_version: '49',
      name: 'React Developer Tools',
      permissions: [ 'file:///*', 'http://*/*', 'https://*/*' ],
      update_url: 'https://clients2.google.com/service/update2/crx',
      version: '3.4.2',
      web_accessible_resources: [ 'main.html', 'panel.html', 'build/backend.js' ]
    }
  }

┗ ----------------------------
┏ Electron -------------------

  Added extension {
    id: 'lmhkpmbekcpmknklioeibfkpmmfibljd',
    name: 'Redux DevTools',
    path: 'C:\\Users\\Christer\\AppData\\Roaming\\Electron\\extensions\\lmhkpmbekcpmknklioeibfkpmmfibljd',
    url: 'chrome-extension://lmhkpmbekcpmknklioeibfkpmmfibljd/',
    version: '2.15.3',
    manifest: {
      background: { persistent: false, scripts: [Array] },
      commands: {
        _execute_page_action: [Object],
        'devtools-bottom': [Object],
        'devtools-left': [Object],
        'devtools-remote': [Object],
        'devtools-right': [Object]
      },
      content_scripts: [ [Object] ],
      content_security_policy: "script-src 'self' 'unsafe-eval'; object-src 'self'; style-src * 'unsafe-inline'; img-src 'self' data:;",
      description: "Redux DevTools for debugging application's state changes.",
      devtools_page: 'devtools.html',
      externally_connectable: { ids: [Array] },
      homepage_url: 'https://github.com/zalmoxisus/redux-devtools-extension',
      icons: {
        '16': 'img/logo/16x16.png',
        '48': 'img/logo/48x48.png',
        '128': 'img/logo/128x128.png'
      },
      key: 'MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAsdJEPwY92xUACA9CcDBDBmbdbp8Ap3cKQ0DJTUuVQvqb4FQAv8RtKY3iUjGvdwuAcSJQIZwHXcP2aNDH3TiFik/NhRK2GRW8X3OZyTdkuDueABGP2KEX8q1WQDgjX/rPIinGYztUrvoICw/UerMPwNW62jwGoVU3YhAGf+15CgX2Y6a4tppnf/+1mPedKPidh0RsM+aJY98rX+r1SPAHPcGzMjocLkqcT75DZBXer8VQN14tOOzRCd6T6oy7qm7eWru8lJwcY66qMQvhk0osqEod2G3nA7aTWpmqPFS66VEiecP9PgZlp8gQdgZ3dFhA62exydlD55JuRhiMIR63yQIDAQAB',
      manifest_version: 2,
      name: 'Redux DevTools',
      options_ui: { chrome_style: true, page: 'options.html' },
      page_action: {
        default_icon: 'img/logo/38x38.png',
        default_popup: 'window.html#popup',
        default_title: 'Redux DevTools'
      },
      permissions: [
        'notifications',
        'contextMenus',
        'tabs',
        'storage',
        '<all_urls>'
      ],
      short_name: 'Redux DevTools',
      update_url: 'https://clients2.google.com/service/update2/crx',
      version: '2.15.3',
      web_accessible_resources: [
        'js/page.bundle.js',
        'js/inject.bundle.js',
        'js/redux-devtools-extension.js'
      ]
    }
  }
  (node:13684) ExtensionLoadWarning: Warnings loading extension at C:\Users\Christer\AppData\Roaming\Electron\extensions\fmkadmapgofadopljbjfkapdkoienihi: Unrecognized manifest key 'browser_action'. Unrecognized manifest key 'minimum_chrome_version'. Unrecognized manifest key 'update_url'. Cannot load extension with file or directory name _metadata. Filenames starting with "_" are reserved for use by the system.
  (node:13684) ExtensionLoadWarning: Warnings loading extension at C:\Users\Christer\AppData\Roaming\Electron\extensions\fmkadmapgofadopljbjfkapdkoienihi: Unrecognized manifest key 'browser_action'. Unrecognized manifest key 'minimum_chrome_version'. Unrecognized manifest key 'update_url'. Cannot load extension with file or directory name _metadata. Filenames starting with "_" are reserved for use by the system.
  (node:13684) ExtensionLoadWarning: Warnings loading extension at C:\Users\Christer\AppData\Roaming\Electron\extensions\lmhkpmbekcpmknklioeibfkpmmfibljd: Unrecognized manifest key 'commands'. Unrecognized manifest key 'homepage_url'. Unrecognized manifest key 'page_action'. Unrecognized manifest key 'short_name'. Unrecognized manifest key 'update_url'. Permission 'notifications' is unknown or URL pattern is malformed. Permission 'contextMenus' is unknown or URL pattern is malformed. Permission 'tabs' is unknown or URL pattern is malformed. Cannot load extension with file or directory name _metadata. Filenames starting with "_" are reserved for use by the system.
  (node:13684) ExtensionLoadWarning: Warnings loading extension at C:\Users\Christer\AppData\Roaming\Electron\extensions\lmhkpmbekcpmknklioeibfkpmmfibljd: Unrecognized manifest key 'commands'. Unrecognized manifest key 'homepage_url'. Unrecognized manifest key 'page_action'. Unrecognized manifest key 'short_name'. Unrecognized manifest key 'update_url'. Permission 'notifications' is unknown or URL pattern is malformed. Permission 'contextMenus' is unknown or URL pattern is malformed. Permission 'tabs' is unknown or URL pattern is malformed. Cannot load extension with file or directory name _metadata. Filenames starting with "_" are reserved for use by the system.

┗ ----------------------------
┏ Electron -------------------

  (node:13684) UnhandledPromiseRejectionWarning: Error: Loading extension at C:\Users\Christer\Source\Repos\fable-elmish-electron-material-ui-demo\node_modules\devtron failed with: The 'manifest_version' key must be present and set to 2 (without quotes). See developer.chrome.com/extensions/manifestVersion.html for details.
  (node:13684) UnhandledPromiseRejectionWarning: Error: Loading extension at C:\Users\Christer\Source\Repos\fable-elmish-electron-material-ui-demo\node_modules\devtron failed with: The 'manifest_version' key must be present and set to 2 (without quotes). See developer.chrome.com/extensions/manifestVersion.html for details.

┗ ----------------------------
┏ Electron -------------------

  (node:13684) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
  (node:13684) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
  (node:13684) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
  (node:13684) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

┗ ----------------------------

[musicm122]

Looks like

(electron) 'BrowserWindow.getDevToolsExtensions' is deprecated and will be removed. Please use 'session.getAllExtensions' instead.

is due to the Fable.Electron Bindings needing to be updated to use Electron 9 conventions
as well as from DevTron.

---

The manifest errors are in part due to DevTron and as yet to be addressed by their developers.
electron-userland/devtron#185

And it looks like there hasn't been any active development on devTron since May 2018 so, not sure there is a replacement.
electron/electron#23676

---

Also, it looks like the electron extension installer is also installing an older version of "Redux DevTools" and "React Developer Tools" but, I'm not 100% sure on that.

I saw that it looks like you have your hands full with this + Fable-Electron + all the other awesome F# stuff you do with.
fable-compiler/fable-electron#6

But, with all that said I thought it would be worth at least documenting these.

[cmeeren]

is due to the Fable.Electron Bindings needing to be updated to use Electron 9 conventions

Not sure what you mean; Fable.Electron is already targeting Electron 9 (the point of this PR is updating to Electron 9).

But, with all that said I thought it would be worth at least documenting these.

Absolutely, thanks a lot for investigating this and linking to the related issues! ❤