Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Comment and detailed FCR info #37

Merged
merged 8 commits into from
Mar 10, 2024
Merged

added Comment and detailed FCR info #37

merged 8 commits into from
Mar 10, 2024

Conversation

flopp999
Copy link
Collaborator

No description provided.

@flopp999 flopp999 requested a review from faanskit March 10, 2024 12:16
@faanskit
Copy link
Owner

Did you commit the init.py? I can only see examples.py, README.md and pyproject.toml.
Also, please fix Flake8 issues (x3)reported.

@flopp999
Copy link
Collaborator Author

Did you commit the init.py? I can only see examples.py, README.md and pyproject.toml. Also, please fix Flake8 issues (x3)reported.

Sorry, I have done changes there but forgot to upload, good catch :)

flopp999 and others added 2 commits March 10, 2024 19:01
added comments and fcrd expanded info
@flopp999
Copy link
Collaborator Author

More to come so not needed to approve now

@flopp999 flopp999 merged commit 38a708e into master Mar 10, 2024
3 checks passed
@flopp999
Copy link
Collaborator Author

@faanskit ops I merged it now. I thought I only updated and sent the changes to complete the PR

@flopp999 flopp999 deleted the flopp999-patch-1 branch March 11, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants