Add a more sensible default config that does not string hyphens

f9webltd · Jan 18, 2021 · 974898a · 974898a
1 parent d215816
commit 974898a
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 5 deletions.
diff --git a/config/f9web-laravel-meta.php b/config/f9web-laravel-meta.php
@@ -85,15 +85,15 @@
  | Title tag replacements
  |--------------------------------------------------------------------------
  |
- | Optionally replace specific title characters. By default a hyphen
- | is replaced by a space
+ | Optionally replace specific title characters. By default, no characters
+ | are replaced.
  |
  */
  'meta-title-replacements' => [
  'enabled' => true,
 
  'search' => [
- '-',
+ '',
  ],
 
  'replace' => [

diff --git a/src/Meta.php b/src/Meta.php
@@ -40,7 +40,7 @@ class Meta implements Htmlable
  public static function setRawTags(array $tags = []): self
  {
  array_map(
- function ($tag) {
+ static function ($tag) {
  self::setRawTag($tag);
  },
  $tags

diff --git a/tests/MetaTitleTagTest.php b/tests/MetaTitleTagTest.php
@@ -92,7 +92,7 @@ public function it_renders_the_expected_title_when_hyphens_are_present()
  // given the title is not set and a default exists
  $this->app['config']->set(
  [
- 'f9web-laravel-meta.fallback-meta-title' => 'App-Name',
+ 'f9web-laravel-meta.fallback-meta-title' => 'App Name',
  'f9web-laravel-meta.meta-title-append' => null,
  ]
  );

diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -32,6 +32,15 @@ public function tearDown(): void
  'enabled' => true,
  'method' => 'route',
  ],
+ 'meta-title-replacements' => [
+ 'enabled' => true,
+ 'search' => [
+ '-',
+ ],
+ 'replace' => [
+ ' ',
+ ]
+ ],
  'removable-uri-segments' => [
  '/public',
  '/index.php',