Make coordinator more resilient #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodant
reviewed
Sep 25, 2024
f321x
force-pushed
the
resilientcoordinator
branch
from
2d02998
to
212ed88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #11
If the coordinator crashes for any reason it now tries to close the old nostr client, wait 60 seconds and then creates a new nostr client (new connections & subscriptions) without losing the pending and ongoing contracts.
While this could maybe designed with more advanced timeout mechanisms this should be able to catch most problems (that happen rarely anyways) without adding too much complexity.