Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add German language on changing lua-timeago languages #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nitestack
Copy link

I wanted this plugin to support the German language. As to the translations, it's not the most optimal, but a good enough one. A really good one would look like this

return {
    justnow = "Gerade eben",
    minute = { singular = "Vor einer Minute", plural = "Vor {} Minuten" },
    hour = { singular = "Vor einer Stunde", plural = "Vor {} Stunden" },
    day = { singular = "Vor einem Tag", plural = "Vor {} Tagen" },
    week = { singular = "Vor einer Woche", plural = "Vor {} Wochen" },
    month = { singular = "Vor einem Monat", plural = "Vor {} Monaten" },
    year = { singular = "Vor einem Jahr", plural = "Vor {} Jahren" },
}

but since this plugin doesn't support it, I adjusted the translations so it works with the plugin. I think the translation is still pretty good.

@f-person
Copy link
Owner

Awesome, thanks! Could you please add the language to https://github.com/f-person/lua-timeago instead? Then I'll update the version of lua-timeago that the plugin has :)

@f-person
Copy link
Owner

I'll need to update the plugin to support this format, though :D

@Nitestack
Copy link
Author

I'll need to update the plugin to support this format, though :D

The PR includes a version without templating. The templating was just in case you implement it in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants