fix: Clear virtual text immediately on cursor move #127
+74
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR #121 introduced some side-effects which made the plugin feel more laggy overall because of how the virtual text got cleared with a delay. This commit retains the original delay behavior for displaying, while immediately clearing the virtual text on cursor move.
|
@jinzhongjia maybe also take a look at this one if you feel like it :) |
|
The effect is great |
bossley9
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #121 introduced some side-effects which made the plugin feel more laggy overall because of how the virtual text got cleared with a delay. This commit retains the original delay behavior for displaying, while immediately clearing the virtual text on cursor move.
Previous behavior:
CleanShot.2024-04-01.at.14.48.11.mp4
Current behavior:
CleanShot.2024-04-01.at.14.47.39.mp4
@bossley9 this doesn't yet switch the default to 0 since it's probably good to 1) reconsider doing that after this change (i would probably still be in favor of that), 2) nicer to do in a separate PR