Use Specific Rust Version in FreeBSD CI

[gierens]

The FreeBSD CI seems to be failing in several PRs due to it using the latest available rust version on FreeBSD (1.83), see discussion: #1336

This attempts to set a specific version by using rustup instead of pkg install. We could also use the version matrix then, I think.

Also, this is the LEET/1337 PR :) ... had to be BSD related of course XD

[gierens]

@cafkafk alright this seems to fix the FreeBSD CI issues as well.

Should we merge this as is, or use a Rust version matrix for BSD as well, what do you think?

[cafkafk]

Should we merge this as is, or use a Rust version matrix for BSD as well, what do you think?

version matrix does sound nice... but we can do that after, let's get the fix merged first, then it can be followed up

---

Also LGTM, nice you found a fix!

[tessus]

Thanks for this.

The reason why using different versions in pipelines is problematic is the following: if you require people to fix clippy issues, those changes might break all other builds. e.g. your current MSRV is 1.74.0 which is 54 weeks old.
It is not only quite possible, but rather likely that features in the current release or release -1 are not available in 1.74.0.

You mentioned it is a good indicator for what is to come. And I agree with you.

However, I use either additional pipelines that use newer versions of rust, sometimes even beta and nightly and/or a version matrix.
The important part is that those pipelines (or versions when using a matrix) must not be required or block merging PRs.

[cafkafk]

MSRV is 1.74.0 which is 54 weeks old.

The reason for this is to maximize compatibility with distributions that lag severely behind stable rust. It also pains me that we have to be this far behind, but when looking across similar rust terminal software, this is fairly normal.

[tessus]

I totally understand that an MSRV can be 1 year old. I'm not saying this is a problem. The issue was that people would make fixes because of clippy issues that came from a much newer rust version. The inconsistency was the problem.

[cafkafk]

I think rustup picks up on the rust-toolchain specified, and if not, the expected developer environemnet is after all the nix devShell, which ensures people are developing on the correct version. It's often sort of a can't lead a horse to water situation with stuff like this, we at least provide the nescesarry tooling for those that are willing to use it, but we can't more without being overly invasive to developers workflows