Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added two new event parameters: localize and all_day. #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mattstein
Copy link

I hacked this for an EE 2.5.5 install using Low Events 1.1.4 and it's been great.

@aarongustafson
Copy link

FYI: prior to 2.6 ee() does not exist.

@mattstein mattstein changed the title Added EE < 2.6.0 compatibility and two new event parameters: localize and all_day. Added two new event parameters: localize and all_day. Apr 9, 2014
@mattstein
Copy link
Author

I'm not sure what I was thinking, but you're right—I edited the pull request title and scrubbed out the stupid. Fantastic headshot, sir.

@aarongustafson
Copy link

No worries. One simple way to go may be something like this:

if ( ! function_exists( 'ee' ) )
{
    $EE =& get_instance();
    function ee()
    {
        return $EE;
    }
}

Granted, I have not tested, but in theory that should resolve the issue.

Fantastic headshot, sir.

Thanks!

@amacneil
Copy link
Member

I don't see how this would work on EE < 2.6 given the use of ee(). That said, I'm totally fine not supporting EE < 2.6 given that it was released nearly a year ago.

@mattstein
Copy link
Author

I know I mentioned the EE < 2.6 support, but I honestly don't know what I was thinking. If you could pay me a kindness and pretend it was somebody else, I'd certainly appreciate it.

{
return ee()->localize->format_date('%Y%m%dT%H%i%s', $time);
if ($localize) {
if (APP_VER >= '2.6.0')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, you can get rid of these lines if EE < 2.6 isn't an issue then :)

@mattstein
Copy link
Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants