-
-
Notifications
You must be signed in to change notification settings - Fork 16.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade eslint #6118
base: master
Are you sure you want to change the base?
deps: upgrade eslint #6118
Conversation
export default [ | ||
{ | ||
// Define language options | ||
languageOptions: { | ||
sourceType: 'module', // or 'commonjs' based on your project | ||
globals: { | ||
// Add any global variables you need | ||
__dirname: true, | ||
process: true, | ||
}, | ||
}, | ||
rules: { | ||
'eol-last': 'error', | ||
'eqeqeq': ['error', 'allow-null'], | ||
'indent': ['error', 2, { MemberExpression: 'off', SwitchCase: 1 }], | ||
'no-trailing-spaces': 'error', | ||
'no-unused-vars': [ | ||
'error', | ||
{ | ||
vars: 'all', | ||
args: 'none', | ||
ignoreRestSiblings: true, | ||
} | ||
], | ||
}, | ||
}, | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the config will require a team agreement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After i upgrade eslint, it need additional file config, and no need eslintrc yml, eslintignore. eslint config is the result converted from eslintrc, and i dont add rules or changes rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same #6109 (review)
Related: #6103 (comment)