Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade eslint #6118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

agungjati
Copy link

@agungjati agungjati commented Oct 31, 2024

Related: #6103 (comment)

@UlisesGascon UlisesGascon changed the title Master fix/upgrade eslint deps: upgrade eslint Nov 1, 2024
@UlisesGascon UlisesGascon self-assigned this Nov 1, 2024
Comment on lines +1 to +27
export default [
{
// Define language options
languageOptions: {
sourceType: 'module', // or 'commonjs' based on your project
globals: {
// Add any global variables you need
__dirname: true,
process: true,
},
},
rules: {
'eol-last': 'error',
'eqeqeq': ['error', 'allow-null'],
'indent': ['error', 2, { MemberExpression: 'off', SwitchCase: 1 }],
'no-trailing-spaces': 'error',
'no-unused-vars': [
'error',
{
vars: 'all',
args: 'none',
ignoreRestSiblings: true,
}
],
},
},
];
Copy link
Member

@UlisesGascon UlisesGascon Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the config will require a team agreement.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After i upgrade eslint, it need additional file config, and no need eslintrc yml, eslintignore. eslint config is the result converted from eslintrc, and i dont add rules or changes rule.

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants