Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add funding field (v5) #6064

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Add funding field (v5) #6064

merged 1 commit into from
Oct 20, 2024

Conversation

bjohansebas
Copy link
Member

@bjohansebas bjohansebas commented Oct 16, 2024

Express now has an Open Collective, it would be good to add this field.

Related: expressjs/discussions#228

@UlisesGascon UlisesGascon merged commit 94546a3 into expressjs:master Oct 20, 2024
19 checks passed
@UlisesGascon UlisesGascon mentioned this pull request Oct 29, 2024
@wesleytodd
Copy link
Member

wesleytodd commented Oct 29, 2024

I was reviewing the changes in the proposed 5.0.2 and noticed this. I am wondering if this was done too soon? We dont have a plan for what we are doing with this money and this will start advertising to people as soon as this goes out. I am not sure it is an issue, but seeing this land so quickly without much discussion I would just like to flag this to the rest of the @expressjs/express-tc in case anyone is opposed.

This will now show in the post install logs, and then direct folks to our OC. Bringing attention to the page which is not really even fully setup yet. (EDIT: has the entire TC actually logged in and accepted the invite @sheplu sent out? EDIT 2: I see so here: https://opencollective.com/express#category-ABOUT)

I am a BIG fan of this in general, and would not have blocked this. But I think that we probably should have left this open for longer and explicitly tagged the TC in it before we merged. Just to make sure anyone who may have an issue with this going directly to end users had a chance to say something. Always better with things around funding to go slow and steady imo.

@wesleytodd
Copy link
Member

I believe folks have generally agreed we are alright to start promoting this. We have a small proposal for wording about what we might allow spending any money collected on, and I will ask if we are good to post that outside of the slack today. Hopefully we are then good to just charge forward with promoting it.

@bjohansebas bjohansebas deleted the funding branch October 31, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants