Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ add discarded middleware test #5819

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions test/app.router.js
Original file line number Diff line number Diff line change
Expand Up @@ -1130,6 +1130,56 @@ describe('app.router', function(){
var app = express();
assert.strictEqual(app.get('/', function () {}), app)
})

it('should should not use disposed router/middleware', function(done){
wesleytodd marked this conversation as resolved.
Show resolved Hide resolved
// more context: https://github.com/expressjs/express/issues/5743#issuecomment-2277148412

var app = express();
var router = new express.Router();

router.use(function(req, res, next){
res.setHeader('old', 'foo');
next();
});

app.use(function (req, res, next) {
return router.handle(req, res, next);
});

app.get('/', function(req, res, next){
res.send('yee');
next();
});

request(app)
.get('/')
.expect('old', 'foo')
.expect(function(res) {
if (typeof res.headers['new'] !== 'undefined') {
throw new Error('`new` header should not be present');
}
})
.expect(200, 'yee', function(err, res) {
if (err) return done(err);

router = new express.Router();

router.use(function(req, res, next){
res.setHeader('new', 'bar');
next();
});

request(app)
.get('/')
.expect('new', 'bar')
.expect(function(res) {
if (typeof res.headers['old'] !== 'undefined') {
throw new Error('`old` header should not be present');
}
})
.expect(200, 'yee', done);
});
})
})

function supportsRegexp(source) {
Expand Down
Loading