remove array-flatten dependency, no longer necessary #5219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced array-flatten dependency with the new flat() method from JavaScript, which is supported in Node.js version 11.0.0 and above. This simplifies the code and reduces the number of dependencies. Proposed change for Express.js v5.
blakeembrey
reviewed
Jun 30, 2023
lib/application.js
Outdated
| @@ -211,7 +210,7 @@ app.use = function use(fn) { | |||
| } | |||
| } | |||
|
|
|||
| var fns = flatten(slice.call(arguments, offset)); | |||
| var fns = slice.call(arguments, offset).flat() | |||
There was a problem hiding this comment.
You need flat(Infinity) for the same behavior.
There was a problem hiding this comment.
Keep in mind that changing this is a breaking change, so you'd want to be making the change in Express.js v5 and not to the current v4 release.
There was a problem hiding this comment.
Indeed, based on the test results, these changes are intended for a future version of Express.
Sorry for wanting to remove your dependency! 🤣
There was a problem hiding this comment.
Now that V5 is out, could this PR be revisited?
There was a problem hiding this comment.
A similar change was merged in #5677 which is in v5.
benjaminPla
force-pushed
the
remove-array-flatten
branch
from
d4d9837
to
e284612
Compare
|
Closing as #5677 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced array-flatten dependency with the new flat() method from JavaScript, which is supported in Node.js version 11.0.0 and above. This simplifies the code and reduces the number of dependencies