TS generics support for checkSchema function #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedeci
requested changes
Feb 5, 2021
There was a problem hiding this comment.
We can't default to any when no type is specified because ValidationChain would not override it.
// this is the result we get
(req: any, res: any, next: any): voidThe only solution is the one suggested, but I'm not 100% satisfied with that.
/cc @gustavohenke
| @@ -9,11 +9,11 @@ import { InternalRequest, Location } from '../base'; | |||
| import { bindAll } from '../utils'; | |||
| import { ContextBuilder } from '../context-builder'; | |||
|
|
|||
| export function check( | |||
| export function check<Req = any, Res = any, NextFn = any>( | |||
There was a problem hiding this comment.
Suggested change
| export function check<Req = any, Res = any, NextFn = any>( | |
| export function check<Req = Request, Res = any, NextFn = (error?: any => void)>( |
There was a problem hiding this comment.
I would even go one step further and make it Req extends Request instead
| @@ -57,10 +57,17 @@ export type ValidationSchema = Schema; | |||
| const validLocations: Location[] = ['body', 'cookies', 'headers', 'params', 'query']; | |||
| const protectedNames = ['errorMessage', 'in']; | |||
|
|
|||
| export function checkSchema(schema: Schema, defaultLocations: Location[] = validLocations) { | |||
| export function checkSchema<Req = any, Res = any, NextFn = any>( | |||
There was a problem hiding this comment.
Suggested change
| export function checkSchema<Req = any, Res = any, NextFn = any>( | |
| export function checkSchema<Req = Request, Res = any, NextFn = (error?: any => void)>( |
gustavohenke
force-pushed
the
master
branch
2 times, most recently
from
3177f64
to
6e160b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.