New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(matchedData): add discardUndefined
option when selecting fields
#1275
base: master
Are you sure you want to change the base?
feat(matchedData): add discardUndefined
option when selecting fields
#1275
Conversation
@gustavohenke Could you check this PR please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks like a good new feature, there are some changes to publish this in a minor version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks like a good new feature, there are some changes to publish this in a minor version.
ignoreUndefined
option when selecting fields
Also, docs should be updated too once we are good to go with the implementation and the new API. |
f145801
to
d23f82e
Compare
I update docs, you can check |
@fedeci I updated code to keep signature of context. You can check again |
I also changed my mind on the naming of |
I think it is also good name. |
ignoreUndefined
option when selecting fieldsdiscardUndefined
option when selecting fields
Description
Add
ignoreUndefined
toincludeOptionals
inmatchedData
ignoreUndefined
allows user to pass optional values which aren't undefined like null and falsy values.It keeps current behaviour and allow user to customize matchedData.
Closes #1048
Closes #1175
Closes #1273
To-do list