Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guide/manually-running) typescript example should use ContextRunner #1261

Conversation

dillonstreator
Copy link
Contributor

@dillonstreator dillonstreator commented Nov 9, 2023

Description

The "manually running" guide's typescript example should use ContextRunner instead of ValidationChain as it is a more minimal interface required by the example helper.

To-do list

  • I have added tests for what I changed.
  • This pull request is ready to merge.

Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the suggestion. It's even documented this way 🤦

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 472ad7f on dillonstreator:doc-manual-run-context-runner
into 28a8d5f on express-validator:master.

@gustavohenke gustavohenke merged commit 6069db8 into express-validator:master Nov 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants