ci: add old node versions to CI #1113
Conversation
|
Oh, the version of jest we are using is not supporting node 8, I will fix it. |
There was a problem hiding this comment.
I don't think we need to support such old versions. They have reached EOL already.
Also parts of the code may not work, e.g. https://github.com/express-validator/express-validator/releases/tag/v6.4.0 this might be gibberish
|
We are still mentioning support for Node 8 both in the readme and in the package.json. I 100% agree we should remove it (maybe also Node 10), but we need to wait for a major to definitely cancel them. |
|
Ouch this has totally been an oversight of mine. I don't think that it'd work on Node 8 anyway. |
gustavohenke
dismissed
their stale review
I totally misread the release link I posted before 🤦 it might actually work, but I still don't think we should support Node <12. WDYT we should do?
gustavohenke
force-pushed
the
master
branch
2 times, most recently
from
3177f64
to
6e160b1
Compare
Description
Related to #1112
To-do list