[cli] Fix HTTPS tunneling for usernames with dot #28692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
approved these changes
May 9, 2024
gabrieldonadel
force-pushed
the
@gabrieldonadel/fix-ngrok-subdomains
branch
from
dbb8703
to
7ad1259
Compare
expo-bot
added
bot: passed checks
gabrieldonadel
added a commit
that referenced
this pull request
May 14, 2024
As highlighted in #27027 (comment), users with `.` in their usernames are unable to use HTTPS tunneling due to a limitation of our SSL certificate, where we can only have one level deep wild card domains. Update `_getIdentifyingUrlSegmentsAsync` to filter out `.` when slugifying the username. This shouldn't cause any clashes given that we concat the username with `getProjectRandomnessAsync()` `yarn start --tunnel` using an account with `.` in the username <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
wodin
reviewed
May 14, 2024
| @@ -51,7 +51,8 @@ export class AsyncNgrok { | |||
| return [ | |||
| // NOTE: https://github.com/expo/expo/pull/16556#discussion_r822944286 | |||
| await this.getProjectRandomnessAsync(), | |||
| slugify(username), | |||
| // Strip out periods from the username to avoid subdomain issues with SSL certificates. | |||
| slugify(username, { remove: /\./ }), | |||
There was a problem hiding this comment.
I see that the slugify docs say this:
- If the value of
removeis a regular expression, it should be a character class and only a character class. It should also use the global flag. (For example:/[*+~.()'"!:@]/g.) Otherwise, the remove option might not work as expected.- If the value of
removeis a string, it should be a single character. Otherwise, theremoveoption might not work as expected.
So it seems they're saying you should use '.' or /[.]/g
However, I tested /\./ and it seems to work fine! I suppose their recommendation is just a lie to children?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As highlighted in #27027 (comment), users with
.in their usernames are unable to use HTTPS tunneling due to a limitation of our SSL certificate, where we can only have one level deep wild card domains.How
Update
_getIdentifyingUrlSegmentsAsyncto filter out.when slugifying the username. This shouldn't cause any clashes given that we concat the username withgetProjectRandomnessAsync()Test Plan
yarn start --tunnelusing an account with.in the usernameChecklist
npx expo prebuild& EAS Build (eg: updated a module plugin).