Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back local create-expo-module templates and fix require error. #28673

Merged
merged 4 commits into from May 13, 2024

Conversation

aleqsio
Copy link
Contributor

@aleqsio aleqsio commented May 8, 2024

Why

@brent reverted ac6609f in bac067c due to crashes.
We want to land it back on main.

How

require was looking for the expo package version in .npx instead of in the project directory.

I'm fixing this by using require.resolve and passing cwd as a paths directory.

Test Plan

I've now made sure that this is using the package version from the actual project, not from the monorepo.
Uploading image.png…

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label May 8, 2024
@aleqsio aleqsio requested review from tsapeta and brentvatne May 8, 2024 09:52
@aleqsio aleqsio requested a review from tsapeta May 9, 2024 11:34
@aleqsio aleqsio merged commit 8c32982 into main May 13, 2024
10 checks passed
@aleqsio aleqsio deleted the @aleqsio/fix-create-expo-module-template branch May 13, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants