Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): use same icons for adb-over-wifi connected devices as ios prompt #28622

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented May 4, 2024

Why

This applies the same (icon) styling for Android devices connected through ADB-over-wifi, as the iOS device prompts.

USB-only Network-only USB & Network
USB-only prompt Network-only prompt USB & Network prompt

How

  • Copied icon from expo run:ios -d (🌐)
  • Added connectionType to Android devices based on the check:
    • If device is an actual device, and includes _adb-tls-connect, its network (see here)
    • If device is an actual device, and includes usb:, its USB (see devices -l when using usb/wifi adb connections)

Test Plan

  • Open your device developer settings
  • Go to "Wireless debugging"
  • Enable "Use wireless debugging"
  • $ adb pair <ip>:<port> <pairing-code>
    • You can find the pairing code on "Pair device with pairing code".
  • $ adb devices -l
    • This should list the Android device, when not connected through USB
  • $ expo run:android -d
    • Should show the wifi-connected device as option too

Checklist

@byCedric byCedric requested a review from EvanBacon as a code owner May 4, 2024 12:30
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 4, 2024
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants