Chore: Fix RuntimeError: ... got Future <..> attached to a different loop #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loop due to creation of new event loops
dosubot
bot
added
the
size:XS
jjmachan
reviewed
May 21, 2024
| @@ -96,7 +99,6 @@ def run(self): | |||
| results = self.loop.run_until_complete(self._aresults()) | |||
| finally: | |||
| self.results = results | |||
| self.loop.stop() | |||
There was a problem hiding this comment.
Thanks a lot for putting the effort to fix this issue ❤️ 🙂
There was a problem hiding this comment.
Because if you use get_event_loop from a jupyter notebook you obtain the loop of the own jupyter, thus closing it might raise some problems. There might be another solution but I thought it was the most straightforward one.
There was a problem hiding this comment.
Thanks to you for creating such an awesome library!
There was a problem hiding this comment.
Because if you use get_event_loop from a jupyter notebook you obtain the loop of the own jupyter, thus closing it might raise some problems.
Thank you so much for this! 🙇♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #963 I commented about the RuntimeError when trying to use TestsetGenerator.
In issue #681 you discussed that using get_event_loop() was the optimal way to solve the issue but it had a Deprecation warning.
In newer python versions get_event_loop() raises a RuntimeError when no event loop is active. Thus we can avoid creating unnecessary new loops that seem to be the problem that was mentioned in both issues.
I have modified the code the least possible to make it clear what I intended to, although in this setup runner could be avoided as was proposed in #689
Setup:
Ragas version: 0.1.7
Python version: Python 3.10.13