fix:the expected value has 8 chunks, name test function should reflect that, changing from 7 to 8 #150
Conversation
|
This comes directly from the problem canonical data. Do you have reason to suspect the canonical data is wrong? |
|
@1ethanhansen see the name of the test function? It states seven chunks, but the error is, that there are eight chunks expected. And I guess if I read it correct if would have to make a slight adjustment. Also instructions state c >= r Or is it the other way around? Then maybe the wording is wrong, or my understanding of chunks is wrong. And c stands for chunks and it's like character length of a word? So what is that canonical data? If that is wrong, does it have to be fixe in canonical data and imported into this repo? |
|
Maybe just rename the test? Imho I would not call it chunks. https://www.cambridge.org/us/cambridgeenglish/news/how-do-you-know-chunk-when-you-see-one/ |
|
The original As described in the problem specification, |
|
Not everyone dominates English very well in this world and think about the audience of exercises. I am not sure if chunk is kind of a real word. But anyways. I agree to continue using chunks, but change the number in the name of the test from 7 to 8. |
and also reverting to original expect value
kivi
changed the title
| @@ -42,7 +42,7 @@ fn test_8_character_plaintext_results_in_3_chunks_the_last_one_with_a_trailing_s | |||
| assert ciphertext(phrase) == expect | |||
| } | |||
|
|
|||
| fn test_54_character_plaintext_results_in_7_chunks_the_last_two_with_trailing_spaces() { | |||
| fn test_54_character_plaintext_results_in_8_chunks_the_last_two_with_trailing_spaces() { | |||
There was a problem hiding this comment.
I'm hesitant to change this without the source problem specifications changing. Could you also open a PR to change the description on problem-specification and tag meplease? Then I'll be happy to merge this in!
Seven chunks should be correct.
I am not sure about last two chunks, can the chunk before last one have 7 chars? If so, then this should fix it.
But it is not clear to me reading the instruction of the exercise.