Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add yacht exercise #1423

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add yacht exercise #1423

wants to merge 5 commits into from

Conversation

xavdid
Copy link

@xavdid xavdid commented Feb 2, 2024

Adds the yacht exercise. I copied the tests from the JS track and added my own TS implementation (which roughly mirrors my Elixir approach).

Most files were generated by configlet. Cleared in the PR in the forum.

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Feb 2, 2024
@ErikSchierboom ErikSchierboom reopened this Feb 2, 2024
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @SleeplessByte do the actual review of the TS code

exercises/practice/yacht/.meta/config.json Outdated Show resolved Hide resolved
xavdid and others added 2 commits February 2, 2024 09:01
@SleeplessByte
Copy link
Member

Blocked by #1427

@ErikSchierboom
Copy link
Member

@SleeplessByte I've merged main into this branch to unblock.

@xavdid
Copy link
Author

xavdid commented Feb 29, 2024

@SleeplessByte is there anything else I need to do on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants