-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impliment new template based generator #1730
Open
meatball133
wants to merge
28
commits into
main
Choose a base branch
from
add-new-generator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
77a991b
Impliment basic prototype as proof of concept
meatball133 039911c
Add ci and more tests
meatball133 8e3afbe
Update gemfile.lock to include toml-rb
meatball133 d278534
Merge branch 'main' into add-new-generator
meatball133 5c27b41
Fix rubocop and fix ci
meatball133 b1f131f
Format files
meatball133 7004988
EOL for every line in text file
kotp 067df32
Generator now executable and changes based on feedback
meatball133 653f629
Fix interpreter name
kotp 4960f96
Merge branch 'main' into add-new-generator
meatball133 39bf79b
Add missing name key in ci file
meatball133 7fb52c5
Fix execution path of ci scripts
meatball133 e1c69f4
Remove Crystal image refernce and fixes to ci
meatball133 79b00d1
Bump rubocop version and add missing actions checkout
meatball133 f806548
Test adding bundle install
meatball133 bbad039
Test uppdating gemfile
meatball133 b6d2e9e
Change to using `bundle exec`
meatball133 98d267d
Make the generate script use the same rubocop config as the repo
meatball133 68d4671
Test rollback to rubocop 1.50
meatball133 76504b5
Update readme to reflect recent changes
meatball133 00af4d0
Split utils methods into its own module
meatball133 492b44b
Breakout helper method and exception class
kotp f40f4c4
Verify now creates a file in exercise directory to get same formattin…
meatball133 769dee3
Changes based on feedback and add more tasks to rakefile
meatball133 754006b
Update bin/generate
meatball133 9932b77
Changes based on feedback
meatball133 adc9d0c
Update tests to reflect rename of `skip?`
meatball133 6e6bcb0
Update test names
meatball133 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be aware that this syntax is relatively new, and so we should ensure that the minimum Ruby version is set to allow for this "valueless hash" syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean it is tooling and we have set the ruby version to 3.3 so I think we dont have to have backwards compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means that it is backward compatible to 3.3.0, up to 3.3.6, currently. Locally I am running 3.3.6, and so the backward compatibility is there.