Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the test suite #343

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Update the test suite #343

merged 1 commit into from
Jan 30, 2024

Conversation

glaxxie
Copy link
Contributor

@glaxxie glaxxie commented Jan 25, 2024 •
edited
Loading

Previous test were passed even when the capitalization doesn't match due to -Be check instead of -BeExactly
This fix the exercise in preparation for #48in24
Edited: I added in [no important files changed] to see if it would pass
[no important files changed]

@glaxxie
Update the test suite
cceae3f 
Previous test were passed even when the capitalization doesnt match
ErikSchierboom
ErikSchierboom approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@glaxxie glaxxie added x:action/fix Fix an issue x:rep/tiny Tiny amount of reputation labels Jan 30, 2024
@glaxxie glaxxie merged commit 40ec5b3 into exercism:main Jan 30, 2024
4 of 5 checks passed
@glaxxie glaxxie deleted the acronym_fix branch February 18, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
x:action/fix Fix an issue x:rep/tiny Tiny amount of reputation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glaxxie @ErikSchierboom