[New Exercise]: Killer Sudoku Helper #284
Conversation
|
|
||
| Throw "Please implement this function" | ||
| } | ||
|
|
There was a problem hiding this comment.
There are a few trailing new lines, it is a tiny bit but it is an easy fix
| $got = Invoke-KillerSudokuHelper -Sum 7 -Size 3 -Exclude @() | ||
| $want = @( ,@(1, 2, 4)) | ||
|
|
||
| ,$got | Should -BeExactly $want |
There was a problem hiding this comment.
I don't think this, , is intended to be here.
|
|
||
| It "Cage with only 1 possible combination" { | ||
| $got = Invoke-KillerSudokuHelper -Sum 7 -Size 3 -Exclude @() | ||
| $want = @( ,@(1, 2, 4)) |
There was a problem hiding this comment.
I think it is sorta ugly having the , before the array, when I removed the , mentioned in the comment above, it does work to remove that.
There was a problem hiding this comment.
Removing the "," indeed the test still work. My reason for it was how powershell unroll their array depending on context.
$want = @( @(1, 2, 4))
$want.Count will be equal 3.
However $want = @( ,@(1, 2, 4))
$want.Count will be equal 1.
Technically speaking, want count should only be 1, because there is only one possible way to fill out the cells.
For this problem, it probably doesnt matter regardless when the array solution only consist of one solution of inner array.
But I think there should be an exercise to teach students about this behavior later
-Fix some blank lines and update test file
No description provided.