Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-compile to Scala 3 #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cross-compile to Scala 3 #34

wants to merge 1 commit into from

Conversation

Z1kkurat
Copy link
Contributor

@Z1kkurat Z1kkurat commented May 7, 2023

Notes:

  1. I had to duplicate common code and remove scala directory, leaving scala-2and scala-3 to make coveralls happy as it considered src/main/scala to be a parent of src/main/scala-2, see run https://github.com/evolution-gaming/play-json-tools/actions/runs/4907729806/jobs/8763025284?pr=34
  2. Had to remove scalacOptsFailOnWarn := Some(false) as there's no version of the compiler-opts plugin for Scala 3 and I failed to figure out how to work around SBT to pass it only to Scala 2 builds. Inserted @nowarn manually
  3. All modules of the project are cross-compiled!

@Z1kkurat Z1kkurat changed the title Cross-compile generic module to Scala 3 [WIP] Cross-compile generic module to Scala 3 May 7, 2023
@coveralls
Copy link

coveralls commented May 7, 2023

Coverage Status

coverage: 72.222% (-2.3%) from 74.561%
when pulling a29f47a on generic-scala3
into bb1ceb3 on master.

@Z1kkurat Z1kkurat changed the title [WIP] Cross-compile generic module to Scala 3 [WIP] Cross-compile modules to Scala 3: play-json-generic, play-json-circe May 7, 2023
@Z1kkurat Z1kkurat changed the title [WIP] Cross-compile modules to Scala 3: play-json-generic, play-json-circe [WIP] Cross-compile to Scala 3 May 8, 2023
@Z1kkurat Z1kkurat changed the title [WIP] Cross-compile to Scala 3 Cross-compile to Scala 3 Jul 4, 2023
@plokhotnyuk
Copy link
Contributor

@Z1kkurat Will it solve missing com.evolutiongaming:play-json-jsoniter_3:x.y.z since v0.10.3?

@Z1kkurat
Copy link
Contributor Author

Z1kkurat commented Nov 3, 2023

@Z1kkurat Will it solve missing com.evolutiongaming:play-json-jsoniter_3:x.y.z since v0.10.3?

@plokhotnyuk I'm not sure. That specific module is already declared to be cross-compiled to Scala 3, so if the artifact is missing then it means publish command doesn't take it into account (I have next to no idea how it works in relation to these settings) and it had to be published manually. My understanding is that declaring Scala 3 for all modules can solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants