-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp(distribution): replace bech32 address with evm hex address for distribution precompile contract #2241
imp(distribution): replace bech32 address with evm hex address for distribution precompile contract #2241
Conversation
…e and undelegate function
…bech32-to-hex-address
…stribution precompile contract
…h32-to-hex-address
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2241 +/- ##
==========================================
- Coverage 70.53% 70.42% -0.11%
==========================================
Files 291 291
Lines 22617 22657 +40
==========================================
+ Hits 15953 15957 +4
- Misses 5798 5822 +24
- Partials 866 878 +12
|
When executing the make lint-fix command, the following errors are found, but in fact they are only partially duplicated. How do you usually fix these problems?
|
The PR looks good, but we need the same typescript library mentioned in #2200 in order to give solutions to the tools already created for our users. We should be able to finish the review and merge it as soon as the typescript lib is available. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
Not Stale |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
@luchenqun can you reopen this PR? I'll close this as it has too many conflicts |
Description
Please review #2200 first, because this is modified based on this PR
More details see before #2122