Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsValidJSON() descriptor #1325

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

IsValidJSON() descriptor #1325

wants to merge 2 commits into from

Conversation

gagan-bhullar-tech
Copy link

Added a descriptor for IsValidJSON()

PR closes #1316

@emeli-dral
Copy link
Contributor

Hi @gagan-bhullar-tech ,
thank you for your contribution!
It was pleasure to review it, from the technical point of view everything looks really good 👍

I only have two requests:
1/ one regarding the naming. Could you please rename the descriptor from IsJSONValid() to IsValidJSON(). We prefer to maintain consistency across all descriptors by using statement formats rather than questions for the naming convention.

2/ and one more regarding the dosc. Could you please add the descriptor to the list of all descriptors under Text Evals heading on the documentation page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a new IsValidJSON() descriptor to Evidently
2 participants
@gagan-bhullar-tech @emeli-dral