Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI(refactor): CI: merge code-check job with type-check job #1304

Merged
merged 1 commit into from
Sep 15, 2024
Merged

UI(refactor): CI: merge code-check job with type-check job #1304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions .github/workflows/ui.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,29 +57,12 @@ jobs:
echo "One or more evidently_python file(s) has changed."
echo "List all the files that have changed: ${{ steps.changed-files.outputs.evidently_python_all_changed_and_modified_files }}"

code-check:
ui-code-check:
name: UI code-check
runs-on: ubuntu-22.04
needs: changed_files
if: ${{ github.event.pull_request.draft == false && (needs.changed_files.outputs.ui_any_modified == 'true' || needs.changed_files.outputs.evidently_python_any_modified == 'true') }}

steps:
- name: ⬇️ Checkout repo
uses: actions/checkout@v4

- name: 📥 Install ui dependencies
uses: ./.github/share-actions/ui-node-pnpm-install

- name: 🔬 Check code quality
working-directory: ui
run: pnpm code-check

ui-type-check:
name: UI type-check
runs-on: ubuntu-22.04
needs: changed_files
if: ${{ github.event.pull_request.draft == false && (needs.changed_files.outputs.ui_any_modified == 'true' || needs.changed_files.outputs.evidently_python_any_modified == 'true') }}

steps:
- name: ⬇️ Checkout repo
uses: actions/checkout@v4
Expand All @@ -94,6 +77,10 @@ jobs:
working-directory: ui
run: pnpm type-check

- name: 🔬 Check code quality
working-directory: ui
run: pnpm code-check

ui-deps-analyze:
name: UI deps analyze
runs-on: ubuntu-22.04
Expand Down