Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes evidentlyai/evidently#1030 negative values on axes #1183

Conversation

GwenVCX
Copy link
Contributor

@GwenVCX GwenVCX commented Jul 3, 2024

Fixes #1030 Weird labelling for y-axis in some error plots for negative values

@GwenVCX
Copy link
Contributor Author

GwenVCX commented Jul 3, 2024

Current state
current_state

After Fix
after_fix

@emeli-dral emeli-dral requested a review from mike0sv July 6, 2024 19:52
@GwenVCX GwenVCX marked this pull request as draft July 8, 2024 03:04
@GwenVCX GwenVCX marked this pull request as ready for review July 8, 2024 04:20
@mike0sv
Copy link
Collaborator

mike0sv commented Jul 10, 2024

Please merge latest commits from main to fix pip-audit 🤗

@emeli-dral emeli-dral requested review from DimaAmega and mike0sv and removed request for mike0sv July 15, 2024 13:05
@DimaAmega
Copy link
Collaborator

DimaAmega commented Jul 15, 2024

Hi @GwenVCX

Thanks a lot for this PR! This made me pay more attention to this known issue, and, in fact, I found a more appropriate solution to fix this problem. So, please, merge this PR in your evidently fork :)

I also added a few comments in PR in order to explain solution, but basically, we just need to set utf-8 charset in the resulting html file

Copy link
Collaborator

@DimaAmega DimaAmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GwenVCX GwenVCX requested a review from DimaAmega July 22, 2024 05:29
@DimaAmega DimaAmega merged commit bb8c809 into evidentlyai:main Jul 22, 2024
26 checks passed
@GwenVCX GwenVCX deleted the fix/weird-labelling-for-y-axis-negative-numbers branch July 22, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird labelling for y-axis in some error plots
3 participants