Skip to content

Commit

Permalink
mypy
Browse files Browse the repository at this point in the history
  • Loading branch information
mike0sv committed Jul 11, 2024
1 parent 018394b commit c3c9c55
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 4 deletions.
41 changes: 37 additions & 4 deletions src/evidently/ui/workspace/cloud.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,17 @@
from typing import BinaryIO
from typing import Dict
from typing import List
from typing import Literal
from typing import NamedTuple
from typing import Optional
from typing import Type
from typing import Union
from typing import overload
from uuid import UUID

import pandas as pd
from requests import HTTPError
from requests import Response

from evidently.ui.api.models import OrgModel
from evidently.ui.api.models import TeamModel
Expand All @@ -24,6 +28,7 @@
from evidently.ui.workspace.remote import NoopBlobStorage
from evidently.ui.workspace.remote import NoopDataStorage
from evidently.ui.workspace.remote import RemoteMetadataStorage
from evidently.ui.workspace.remote import T
from evidently.ui.workspace.view import WorkspaceView

TOKEN_HEADER_NAME = "X-Evidently-Token"
Expand Down Expand Up @@ -84,17 +89,45 @@ def _prepare_request(
r.cookies[self.token_cookie_name] = self.jwt_token
return r

@overload
def _request(
self,
path: str,
method: str,
query_params: Optional[dict] = None,
body: Optional[dict] = None,
response_model=None,
response_model: Type[T] = ...,
cookies=None,
headers: Dict[str, str] = None,
form_data: bool = False,
):
) -> T:
pass

@overload
def _request(
self,
path: str,
method: str,
query_params: Optional[dict] = None,
body: Optional[dict] = None,
response_model: Literal[None] = None,
cookies=None,
headers: Dict[str, str] = None,
form_data: bool = False,
) -> Response:
pass

def _request(
self,
path: str,
method: str,
query_params: Optional[dict] = None,
body: Optional[dict] = None,
response_model: Optional[Type[T]] = None,
cookies=None,
headers: Dict[str, str] = None,
form_data: bool = False,
) -> Union[Response, T]:
try:
res = super()._request(
path=path,
Expand Down Expand Up @@ -142,7 +175,7 @@ def create_team(self, team: Team, org_id: OrgID = None) -> TeamModel:
def add_dataset(
self, file: BinaryIO, name: str, org_id: OrgID, team_id: TeamID, description: Optional[str]
) -> DatasetID:
response = self._request(
response: Response = self._request(
"/api/datasets/",
"POST",
body={"name": name, "description": description, "file": file},
Expand All @@ -152,7 +185,7 @@ def add_dataset(
return DatasetID(response.json()["dataset_id"])

def load_dataset(self, dataset_id: DatasetID) -> pd.DataFrame:
response = self._request(f"/api/datasets/{dataset_id}/download", "GET")
response: Response = self._request(f"/api/datasets/{dataset_id}/download", "GET")
return pd.read_parquet(BytesIO(response.content))


Expand Down
2 changes: 2 additions & 0 deletions src/evidently/ui/workspace/remote.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ def _request(
response_model: Type[T] = ...,
cookies=None,
headers: Dict[str, str] = None,
form_data: bool = False,
) -> T:
pass

Expand All @@ -111,6 +112,7 @@ def _request(
response_model: Literal[None] = None,
cookies=None,
headers: Dict[str, str] = None,
form_data: bool = False,
) -> Response:
pass

Expand Down

0 comments on commit c3c9c55

Please sign in to comment.