Remove people that disappear from EveryPolitician #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a person gets merged on Wikidata they effectively disappear from EveryPolitician, but we still have them cached in the `country_uuids` table. This change checks for any people that have been removed and deletes the associated `votes` and `country_uuids` tables.
tmtmtmtm
reviewed
Nov 19, 2018
| gb_ids = CountryUUID.where(country_slug: country.slug, legislature_slug: legislature.slug).map(&:uuid) | ||
| missing_uuids = gb_ids - ep_ids | ||
| Vote.where(person_uuid: missing_uuids).delete | ||
| CountryUUID.where(uuid: missing_uuids).delete |
There was a problem hiding this comment.
@chrismytton I'm assuming these are both essentially no-ops if missing_uuids is empty?
I had a quick scan of the Sequel docs, but couldn't spot anything obvious, and as there are no tests for this, I figure it's best to be overly cautious!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a person gets merged on Wikidata they effectively disappear from EveryPolitician, but we still have them cached in the
country_uuidstable. This change checks for any people that have been removed and deletes the associatedvotesandcountry_uuidstables.Fixes #336