add full width to dashboard player and adjust other live views #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Mebareksaf
commented
Feb 14, 2024
Mebareksaf
commented
|
This is too much, you can't even see the whole video without scrolling. |
Shall i only make it take full-width and not length? |
|
Maybe you guys know this, but what you're looking for is 'fit to screen' . Like most players and today's evercam , the video will fit to whichever the limiting dimension happens to be. Open google meet and play with the window size, you will see how it works. (or evercam player) |
Try to use the available height and let the width grow accordingly. |
|
@gBillal i've adjusted it to fill the smallest viewport screen height "h-svh" 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.