Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings menu #47

Merged
merged 13 commits into from
Nov 18, 2023
Merged

Settings menu #47

merged 13 commits into from
Nov 18, 2023

Conversation

MGlolenstine
Copy link
Contributor

@MGlolenstine MGlolenstine commented Nov 14, 2023

I've added a settings menu window under Options -> Settings.

The settings menu currently contains settings for changing the colors of the elements inside of HexView and ASCIIView, and byte grouping.

Theme settings is a CollapsedHeader, which hides the settings to not clutter the UI if not needed.

Setting changes are seen immediately.

Screenshots:

image
image

Closes #10 .

@ethteck
Copy link
Owner

ethteck commented Nov 16, 2023

Just to put it here so it's recorded, this looks awesome! I added a couple more options.. I might add a couple more too. But in the meantime, I think we should have the storing/loading of these settings as part of this PR

Added modal popup warning if you overwrite the previous configuration with workspace created from arguments.
@MGlolenstine
Copy link
Contributor Author

The configuration gets loaded at the startup and saved when the Save Workspace in the File menu is clicked.

If we open the program by passing the arguments (or drag-dropping files onto the executable), the configuration in the current directory will not be loaded, but when the temporary workspace is saved, a modal opens up and warns you that you will overwrite the current configuration.

Copy link
Owner

@ethteck ethteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it yet, which I will soon. In the meantime, here's some stuff I found in the code

src/app.rs Outdated Show resolved Hide resolved
src/app.rs Show resolved Hide resolved
src/app.rs Outdated Show resolved Hide resolved
src/data_viewer.rs Outdated Show resolved Hide resolved
@MGlolenstine
Copy link
Contributor Author

I have addressed the above change requests.

The overwrite modal now looks like this:
image

Does the path have to be relative or absolute?

@ethteck
Copy link
Owner

ethteck commented Nov 18, 2023

I think relative is fine for now. looks good!

@ethteck ethteck merged commit a1ccd2b into ethteck:main Nov 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings panel
2 participants