Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3313
Continuing work towards optimizations in #3293
block.genTransactionsTrie()
Returns the txs trie root for array of
TypedTransaction
This method is used during block building and block validation
An empty trie is contructed from a list of serialized transactions (with the tx index as key)
The root of this trie is the
TransactionsTrieRoot
of a block.trie.batch()
The refactored
trie.batch
method in #3313 demonstrated up to 33% efficiency improvements over the naivefor (tx of txs) {...}
approach.Changes:
block.genTransactionsTrieRoot()
will now construct a trie from a batch input of serialized transactions.This should improve performance during block building and validation
TODO: