EVM: Simple One-Item Peek Cache Experiment #3040
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -1,5 +1,10 @@ | |||
| import { ERROR, EvmError } from './exceptions.js' | |||
|
|
|||
| type PeekCache = { | |||
| num: number | |||
There was a problem hiding this comment.
This num should be the same as peekArray.length - right?
There was a problem hiding this comment.
Yes, maybe both wrongly named and not necessary on second thought. 😂
|
Interesting, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick experiement with a very simple one-item peek cache - following up a bit on the work on the hybrid stack from #3029 - to see if this somewhat mitigates our cleaner but a bit heavier double access stack structure through the separation of gas calculation (
gas.ts) and opcode execution (functions.ts).Results are not so clear, might bring a performance gain, might not.
This would need some profiler additions I guess to be more on the save side (will talk through with @jochem-brouwer).