core, cmd, eth, internal, miner: rework makeReceipt #30791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
requested review from
lightclient,
s1na,
karalabe,
holiman and
MariusVanDerWijden
as code owners
s1na
reviewed
Nov 25, 2024
core/state_processor.go
Outdated
| if hooks := evm.Config.Tracer; hooks != nil { | ||
| if hooks.OnTxStart != nil { | ||
| hooks.OnTxStart(evm.GetVMContext(), tx, msg.From) | ||
| } | ||
| if hooks.OnTxEnd != nil { | ||
| // TODO (rjl493456442) the receipt only contain consensus fields, | ||
| // should we derive the others here? |
There was a problem hiding this comment.
Yes please. I can spot quite a few of these fields being used here https://github.com/streamingfast/go-ethereum/blob/9bf4d2482fb4fc3ea208fa55884c63d56a6858e5/eth/tracers/firehose.go#L576 including TransactionIndex, GasUsed, BlobGasUsed, BlobGasPrice.
rjl493456442
force-pushed
the
slim-receipt
branch
from
7c19e2a
to
9482c09
Compare
|
It might be a bad idea. Internally, Geth assumes the geth-specific fields in receipt are always available and uses them everywhere. For example, Therefore, this change could be dangerous as the assumption could be silently broken. I will close it for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress