Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: implement eip-7702 set code tx #30078

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

all: implement eip-7702 set code tx #30078

wants to merge 31 commits into from
+1,390 −69

Conversation

lightclient
Copy link
Member

@lightclient lightclient commented Jun 26, 2024 •
edited
Loading

Spec: EIP-7702: Set EOA account code

Add a new transaction type that adds a list of [chain_id, address, nonce, y_parity, r, s] authorization tuples. For each tuple, write a delegation designator (0xef0100 ++ address) to the signing account’s code. All code reading operations must load the code pointed to by the designator.

@lightclient lightclient force-pushed the eip-7702 branch 2 times, most recently from bc22287 to 95524bb Compare June 26, 2024 23:31
@rjl493456442
Copy link
Member

Should we propose another EIP to revamp EIP158? Otherwise, as we discussed previously, the leftover storage of an "empty" EOA could be cleared at the end of block.

@lightclient
Copy link
Member Author

@rjl493456442 I think the proposal which will get accepted for devnet-2 and on will avoid the 158 problem, so it's probably okay to just let it play out. ethereum/EIPs#8677

@lightclient lightclient force-pushed the eip-7702 branch 5 times, most recently from ff4dba2 to 955384a Compare July 18, 2024 17:47
@Brechtpd Brechtpd mentioned this pull request Jul 19, 2024
Closed
1 task
@lightclient lightclient force-pushed the eip-7702 branch 2 times, most recently from e3834ac to 20ea148 Compare August 21, 2024 22:41
@lightclient lightclient force-pushed the eip-7702 branch 4 times, most recently from 94389ba to 8578fb7 Compare September 9, 2024 20:24
buddh0
buddh0 reviewed Sep 18, 2024
View reviewed changes
core/state_transition.go Outdated Show resolved Hide resolved
buddh0
buddh0 reviewed Sep 18, 2024
View reviewed changes
core/state_transition.go Outdated Show resolved Hide resolved
buddh0
buddh0 reviewed Sep 19, 2024
View reviewed changes
core/vm/operations_acl.go Outdated Show resolved Hide resolved
buddh0
buddh0 reviewed Sep 19, 2024
View reviewed changes
core/vm/operations_acl.go Outdated Show resolved Hide resolved
@NathanBSC NathanBSC mentioned this pull request Sep 27, 2024
Closed
@buddh0 buddh0 mentioned this pull request Sep 27, 2024
Draft
@ethereum ethereum deleted a comment from Kya123iu Oct 1, 2024
@octavio12345300 octavio12345300 mentioned this pull request Oct 3, 2024
Closed
Kya123iu

This comment was marked as spam.

Sign in to view

@buddh0

This comment was marked as resolved.

Sign in to view
lightclient and others added 29 commits December 2, 2024 15:25
@lightclient @fjl
internal/ethapi: add 7702 tests to eth_estimateGas
3cbf076
@lightclient @fjl
core/vm: make 7702 variants of EXT* ops
ad25935
@lightclient @fjl
core: remove resolve code mechanism from statedb, put in vm
c1a595d
@lightclient @fjl
core: use parse delegation for code check in state transition
2c94cda
@lightclient @fjl
legacypool: don't allow 7702 txs in pool yet
e5acc81
@lightclient @fjl
common: remove zero address
c217e8e
@lightclient @fjl
accounts/external: handle set code tx type in backend
633f1d1
@lightclient @fjl
internal/ethapi: handle set code tx type in transaction args
bedb3cd
@holiman @fjl
core: clarify test a bit
ffe92b7
@fjl
core/types: remove AuthorizationList and use Authorization as value i…
68a3b2e 
…nstead of pointer
@fjl
core/types: change Authorization signature value to uint256
f2e996a
@fjl
core/types: change Authority method to pointer receiver
2191fc3
@fjl
core: fix account reference
6da5145
@fjl
internal/ethapi: remove reference to blob fields in setcode tx
cf7a821
@fjl
core/types: improve authority signature handling
a43caff
@fjl
core: track validation error for authorizations
fdd6348 
It's not strictly necessary, but can be nice for debugging.
@fjl
core: style improvement in applyAuthorization
3554c02
@fjl
core: add comment about nonce update order
281da5f
@fjl
core/vm: add comment about chained EIP-7702 delegations
fc33691
@fjl
core: remove debug print
d01998b
@fjl
cmd/evm: update testdata
91cc0dc
@fjl
graphql: add support for fee parameters of SetCodeTx
e2c7bc7
@fjl
core: improve checks for 7702
49aa230 
- prevent SetCodeTx in create mode (similar to blob tx)
- move check for non-empty auth list to preCheck
@fjl
core: add comment about 7702 state transition error
0b82356
@holiman @fjl
core/state: fix hooks to account for setcode on non-empty code
7b68ae6
@holiman @fjl
core/state: fix journal to account for setcode over non-empty code
4801eca
@fjl
core: reformat comment
3815d14
@fjl
core: clarify delegation deletion flow
0f1a4e5
@fjl
core: more comment
cdf9e53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Voidkai Voidkai Voidkai left review comments

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden left review comments

@lj1nu lj1nu lj1nu left review comments

@marioevz marioevz marioevz left review comments

@buddh0 buddh0 buddh0 left review comments

@rjl493456442 rjl493456442 rjl493456442 left review comments

@sudeepdino008 sudeepdino008 sudeepdino008 left review comments

@zhiqiangxu zhiqiangxu zhiqiangxu left review comments

@holiman holiman holiman left review comments

@Kya123iu Kya123iu Kya123iu requested changes

@fjl fjl fjl approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi is a code owner

@s1na s1na Awaiting requested review from s1na s1na is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
prague
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.