common: Added {Address,Hash}.IsZero()
#29740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're not the first one. I don't think this is gonna fly :) |
|
I understand that you don't want to touch so many places in the code at once (this PR doesn't). People are using this code base as a lib as well, and this is a small but nice extension, that fits with the third common primitive type uint256.Int. cc @holiman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR that adds the utility functions
Address.IsZeroandHash.IsZerothat report if the address or hash has the zero value. The check for the zero value is common and kind of unpleasant (addr == (common.Address{})). Geth alone contains 218 such checks (v1.14.2).