core,params: Don't rewind chain on pre-genesis time changes #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianst
force-pushed
the
seb/pre-genesis-time-changes
branch
from
023be03
to
1c88f2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests
Will test on a devnet.
Additional context
We had a chain rewind on our internal
sepolia-devnet-0on Jan 29 because the Canyon activation time changed from0to1698436800(Fri Oct 27 20:00:00 UTC 2023) when we set Base's Canyon activation time as the canonical time in the superchain-registry but didn't overwrite it to 0 again.This change allows us to overwrite the Canyon activation time on
sepolia-devnet-0back to0without causing another chain rewind.We might want to upstream (parts of) this.
Metadata