fix(forkdiff): update sub definitions to fix hydration #244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates your
fork.yaml
file so that forkdiff binary can successfully build the report page.Under the existing
fork.yaml
file, it fails to build and gives the following error:Tests
I ran forkdiff with the updated changes and was able to successfully build the report page.
Additional context
There is no validation of the file,
fork.yaml
. Additionally, there exists no timestamp or versioning information in the generated report page.I added two hard coded values:
1. the version of the corresponding git hash for go-ethereum, v1.13.8
2. a 'Last Updated' value, using TZ=UTC
Considerations
fork.yaml
should be validated at build, additionally I found no configuration specification for detailing diffing policy or setup.For reference, this is one configuration
This is beyond the scope of this PR, I just thought to mention it, as it makes maintainer job easier.