Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove variable that is always equal to 0 #753

Closed
wants to merge 1 commit into from

Conversation

sorokin
Copy link
Contributor

@sorokin sorokin commented Feb 23, 2020

No description provided.

@eteran
Copy link
Owner

eteran commented Feb 24, 2020

I'm not sure that it's a benefit to remove this particular variable. While there is nothing to the left of "line 0", there could one day be, so having it be a tunable parameter seems to at the very least, do no harm.

@sorokin
Copy link
Contributor Author

sorokin commented Feb 24, 2020

Let me explain why I decided to remove this variable.

I wanted to fix #752 by making separate settings for line{1,2,3,4} for 32- and 64-bit modes. Apparently line{1,2,3,4} are saved to settings while line0 is not. So I decided to remove this asymmetry are removed line0.

But you are right for now line0 can stay.

@eteran
Copy link
Owner

eteran commented Feb 24, 2020

Gotcha makes sense about the settings. Thanks for your efforts in fixing these bugs.

I'm going to close this PR, if it turns out that in the future, there is a tangible benefit to removing this variable, feel free to open another :-).

@eteran eteran closed this Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants