Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unsort #310

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow unsort #310

wants to merge 2 commits into from

Conversation

dfsq
Copy link

@dfsq dfsq commented May 12, 2014

User should be able to clear sorting by clicking column header. In this case sorting will cycle over asc-desc-"no sorting" order.

The behavior is controlled by allowUnsort settings option, which is false by default.

dfsq added 2 commits May 10, 2014 12:22
This is a missing piece of the fix for esvit#284. 01-intro.js should also be fixed otherwise this AMD definition will still be incorrect upon the project build (grunt concat task).
@gunta
Copy link

gunta commented Jun 20, 2014

+1

@enkodellc
Copy link
Contributor

+1 works great. Thanks

@christianacca
Copy link
Collaborator

Hi @dfsq,

I would like to merge the unsort feature. I can do that after some housekeeping tasks are completed.

Can you:

  1. Rebase your changes on top of current master eg: git rebase master
    • necessary as the code base has changed quite a lot since you submitted your pull request
  2. Remove the AMD definition fix as this should be made in another pull request
  3. Add tests for the new functionality
  4. squish the commits into one with the commit msg:

feat(ngTableController): allow column to be unsorted

Thanks
Christian

@chillyistkult
Copy link

Is there any update on this topic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants